-
Notifications
You must be signed in to change notification settings - Fork 4
Add Bit Philology project page #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new content page describing the Bit Philology research project with front matter and narrative sections on scope, methodology, team roles, collaboration, funding/start date, and links. No code or executable logic; content-only addition. Changes
Possibly related issues
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/projects/bitphilology/index.qmd(1 hunks)
🔇 Additional comments (3)
content/projects/bitphilology/index.qmd (3)
1-8: LGTM!The front matter is well-structured with appropriate metadata for a project page.
10-14: LGTM!The project description is clear, comprehensive, and well-articulated. The content effectively communicates the project's scope, context, and methodological approach.
20-24: All team member profile URLs are accessible – each link returned HTTP 200, no changes needed.
vvvyyynet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Sorry for taking that long for reviewing this. I approve so you can merge.
|
@flicksolutions do you understand, why the two checks are failing? Is it because @swillemin-dh made the pull-request via the fork and not inside the DHBern repo? |
@vvvyyynet changed the rules so the checks are allowed to fail. Because just because there is a lintin issue should block... |
Pull request
Proposed changes
Add Bit Philology project page
Types of changes
Checklist